Skip to content

Loosen GRPC requirements.#37817

Merged
tvalentyn merged 3 commits intoapache:masterfrom
tvalentyn:grpc
Mar 11, 2026
Merged

Loosen GRPC requirements.#37817
tvalentyn merged 3 commits intoapache:masterfrom
tvalentyn:grpc

Conversation

@tvalentyn
Copy link
Contributor

Context: We discovered that Go precommit suite was failing (#32324) after GRPC 1.66 update (grpc/grpc#37710).

GRPC team believes that this error is triggered by a somewhat specific usage scenario in the Go postcommit suite, caused by the suite running multiple go tests in parallel and there is not sufficient reason to believe that Beam users would also be affected (cc: @sergiitk to keep me honest).

On the other hand, Beam users are adversely affected by a capped lower bound on grpcio. We still anticipate a proper fix in grpc/grpc#37710, and it might arrive in grpcio==1.72.2. However, given that grpcio==1.72.1 was yanked, we are proceeding with removing the grpc lower bound to ensure that Beam users have a compatible grpc requirement in Beam 2.72.0. Out of caution, we are not planning to update GRPCIO in the default beam SDK containers in 2.72.0, keeping them on 1.65.x. Beam users would be able to install newer versions of GRPCIO though.

Some confidence in this approach is that Beam Python 3.13 users have been on newer versions on GRPC and we are not aware of issues.

GRPC version 1.70.x and earlier are affected by a known issue grpc/grpc#38290 (comment) , hence keeping those out of the allowed range.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses grpcio dependency management by modifying the setup.py file to broaden the acceptable range of grpcio versions for Beam users. The change aims to improve compatibility and flexibility for users installing newer grpcio releases, while carefully maintaining exclusions for versions known to have issues. This consolidation simplifies dependency declarations and mitigates problems encountered with specific grpcio updates.

Highlights

  • Relaxed GRPC Version Constraints: The grpcio dependency in sdks/python/setup.py has been updated to remove specific version exclusions for 1.71.x through 1.78.0. This change allows Beam users to install a wider range of newer grpcio versions, addressing issues with recent releases and a yanked version (1.72.1).
  • Consolidated Python Version Support: The separate grpcio dependency specification previously defined for Python 3.13+ has been removed. The grpcio requirement is now consolidated into a single entry that applies across all supported Python versions.
  • Continued Exclusion of Problematic Versions: Despite the loosening of constraints, known problematic grpcio versions, including 1.70.x and earlier specific versions (e.g., 1.48.0, 1.59.* to 1.69.*), remain explicitly excluded to prevent known compatibility issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/python/setup.py
    • Updated the grpcio dependency specification to allow a broader range of newer versions.
    • Removed specific version exclusions for grpcio versions 1.71.x through 1.78.0.
    • Consolidated grpcio dependency definition across all Python versions by removing the Python 3.13+ specific entry.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/beam_PreCommit_GoPortable.yml
Activity
  • No human activity (comments, reviews) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@tvalentyn
Copy link
Contributor Author

@tvalentyn
Copy link
Contributor Author

R: @potiuk if you have a moment - thanks!

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the grpc side.

@tvalentyn tvalentyn merged commit 8e0736a into apache:master Mar 11, 2026
100 of 103 checks passed
@potiuk
Copy link
Member

potiuk commented Mar 11, 2026

Cooool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants