Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
R: @potiuk if you have a moment - thanks! |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
sergiitk
left a comment
There was a problem hiding this comment.
LGTM from the grpc side.
|
Cooool |
Context: We discovered that Go precommit suite was failing (#32324) after GRPC 1.66 update (grpc/grpc#37710).
GRPC team believes that this error is triggered by a somewhat specific usage scenario in the Go postcommit suite, caused by the suite running multiple go tests in parallel and there is not sufficient reason to believe that Beam users would also be affected (cc: @sergiitk to keep me honest).
On the other hand, Beam users are adversely affected by a capped lower bound on grpcio. We still anticipate a proper fix in grpc/grpc#37710, and it might arrive in grpcio==1.72.2. However, given that grpcio==1.72.1 was yanked, we are proceeding with removing the grpc lower bound to ensure that Beam users have a compatible grpc requirement in Beam 2.72.0. Out of caution, we are not planning to update GRPCIO in the default beam SDK containers in 2.72.0, keeping them on 1.65.x. Beam users would be able to install newer versions of GRPCIO though.
Some confidence in this approach is that Beam Python 3.13 users have been on newer versions on GRPC and we are not aware of issues.
GRPC version 1.70.x and earlier are affected by a known issue grpc/grpc#38290 (comment) , hence keeping those out of the allowed range.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.