feat(trait): allow usage of semver for camel.runtime-version

Closes #5311
apache · Apr 5, 2024 · 0c47c3d · 0c47c3d
1 parent 3757cac
commit 0c47c3d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/pkg/trait/camel.go b/pkg/trait/camel.go
@@ -86,7 +86,7 @@ func (t *camelTrait) Apply(e *Environment) error {
 		}
 	}
 
-	e.RuntimeVersion = t.RuntimeVersion
+	e.RuntimeVersion = e.CamelCatalog.Runtime.Version
 
 	if e.Integration != nil {
 		e.Integration.Status.RuntimeVersion = e.CamelCatalog.Runtime.Version

diff --git a/pkg/trait/camel_test.go b/pkg/trait/camel_test.go
@@ -230,3 +230,19 @@ func TestCamelMatches(t *testing.T) {
 	t2.RuntimeVersion = "3.2.1"
 	assert.False(t, t1.Matches(&t2))
 }
+
+func TestCamelCatalogSemver(t *testing.T) {
+	trait, environment := createNominalCamelTest(true)
+	trait.RuntimeVersion = "2.x"
+	environment.CamelCatalog.CamelCatalogSpec.Runtime.Version = "2.16.0"
+
+	configured, condition, err := trait.Configure(environment)
+	require.NoError(t, err)
+	assert.Nil(t, condition)
+	assert.True(t, configured)
+
+	err = trait.Apply(environment)
+	require.NoError(t, err)
+	// 2.x will translate with 2.16.0 as it is already existing
+	assert.Equal(t, environment.CamelCatalog.CamelCatalogSpec.Runtime.Version, environment.RuntimeVersion)
+}