Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/coverage report workflow #4495

Merged
merged 14 commits into from
Jun 28, 2023
Merged

feat/coverage report workflow #4495

merged 14 commits into from
Jun 28, 2023

Conversation

realMartinez
Copy link
Contributor

  • added a workflow which comments on newly created or updated PRs the change to code coverage those PRs made.
  • the messages can be customized depending on whether the code coverage was changed positively, negatively or was unchanged.

Release Note

NONE

@realMartinez
feat/coverage report workflow
f69f1f6 
- workflow creating comment on PR detailing code coverage  change
@realMartinez
Copy link
Contributor Author

Comment Example

🐫 Thank You for contributing! 🐫
Code Coverage Report

  • Coverage changed from: 39.0% -> 39.2%
  • Coverage difference: +0.2%

@gansheer
Copy link
Contributor

That's very nice !

I love the camel icons 👍 . Would it be difficult to have some icon like with a ✔️ coverage difference >= 0 and maybe some ⚠️ for coverage difference < 0 ?

It could be in the title:
Code Coverage Report ✔️
Code Coverage Report ⚠️

@realMartinez
Copy link
Contributor Author

Not at all, as long as it is supported by markdown it should be fine

@realMartinez
Copy link
Contributor Author

I changed the format, now messages should look like this, for positive code coverage I used the checkmark.

🐫 Thank You for contributing! 🐫

Code Coverage Report ⚠️

  • Coverage changed from: 39.2% -> 39.0%
  • Coverage difference: -0.2%

@squakez
Copy link
Contributor

squakez commented Jun 20, 2023

Great stuff. Question, why the coverage action is failing? It seems it fails with a 403, maybe some permission issue? also, I guess that this very same PR should have the new bot comment.

@realMartinez
Copy link
Contributor Author

Yeah I looked into it and it seems to be a permission issue

@squakez
Copy link
Contributor

squakez commented Jun 28, 2023

No need to run all checks.

@squakez squakez merged commit 437e503 into apache:main Jun 28, 2023
@squakez squakez mentioned this pull request Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squakez squakez squakez approved these changes

@gansheer gansheer gansheer approved these changes

@oscerd oscerd oscerd approved these changes

@claudio4j claudio4j claudio4j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@realMartinez @gansheer @squakez @claudio4j @oscerd