fix: remove empty CRD yaml #4498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes helm installation
squakez
requested changes
Jun 21, 2023
|
thanks @squakez for taking a look! could you elaborate on "completely removing" the files? in the meanwhile i'll take a look at the failed tests |
|
Tests were failing because of some infra problem that should have gone. Don't worry about them. What I meant is that the file should be completely removed. It seems to be a leftover from the previous renaming from |
|
I'm colsing this in favour of #4510 - the problem is in the release process which is not taking in account properly the generation of charts when run from release branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4497
Release Note