Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change order of how resources get dumped #4544

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

christophd
Copy link
Contributor

Dump CamelCatalog at the end to avoid heavy log scrolling during failure analysis

@christophd christophd marked this pull request as ready for review July 7, 2023 08:32
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to keep it where it is, in the sense that CamelCatalog depends directly from IntegrationPlatform. I wonder if we can provide a configuration to render the catalog only on request.

@christophd
Copy link
Contributor Author

@squakez have you seen the catalog still gets dumped but only at the end of the dump output. This is because most of the time you are interested in your integration, build, deployment details and you need to scroll down a lot to get there when the catalog is printed 1st.

I can also move the IP down to where the catalog now lives if this suits better. WDYT?

@squakez
Copy link
Contributor

squakez commented Jul 7, 2023

Okey, then it makes sense to invert completely the order: Integration, kits, build, Ip, catalog.

Dump CamelCatalog at the end to avoid heavy log scrolling during failure analysis
@christophd christophd merged commit 6bcebdd into apache:main Jul 7, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants