fix(#4556): disable creating k8s client in output mode #4557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix #4556. The approach includes:
run
: movecmd.Annotations[offlineCommandLabel] = "true"
toPersistentPreRunE
so that the command got marked as offline earlier in the run.bind
doesn't require this change.GetCmdClient()
only when NOT in offline modescheme.Scheme
forprinters.NewTypeSetter()
function.Fixes: #4556
Release Note