Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing role in helm chart #4630

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Fix missing role in helm chart #4630

merged 1 commit into from
Aug 1, 2023

Conversation

claudio4j
Copy link
Contributor

Fix #4629

  • Also improve doc about helm and minikube installation

Release Note

NONE

oscerd
oscerd requested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just recreate the helm chart for 2.0.0 and not upload a snapshot.

docs/charts/index.yaml Outdated Show resolved Hide resolved
@claudio4j
Fix missing role in helm chart
8be1a9d 
Fix apache#4629

- Also improve doc about helm and minikube installation
squakez
squakez reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care. It seems we missed to sync after the changes done in the new naming of Pipes

helm/camel-k/templates/operator-role.yaml Show resolved Hide resolved
helm/camel-k/templates/operator-role.yaml Show resolved Hide resolved
helm/camel-k/templates/operator-role.yaml Show resolved Hide resolved
@squakez
Copy link
Contributor

squakez commented Aug 1, 2023

I think we should just recreate the helm chart for 2.0.0 and not upload a snapshot.

Yes. Once the changes are merged, we need to backport and I will take care to recreate Helm 2.0 release.

@claudio4j
Copy link
Contributor Author

Pasquale, I forgot to mention the additional apigroup resources, were synced from operator-role.yaml

@squakez squakez merged commit 06a087a into apache:main Aug 1, 2023
14 checks passed
@claudio4j claudio4j deleted the fix_helm branch August 1, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squakez squakez squakez left review comments

@oscerd oscerd oscerd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

camel-k installed with helm does not create cluster role for pipes and kameletbindings
3 participants
@claudio4j @squakez @oscerd