Fix cron trait doc, timer usage is missing information #4633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudio4j
force-pushed
the
fix_cron
branch
2 times, most recently
from
fe53a42
to
2ef6194
Compare
|
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
Fix doc related to when the timer is materialized as a CronJOb
|
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
squakez
approved these changes
Aug 2, 2023
| @@ -27,8 +27,11 @@ package trait | |||
| // Integrations that start from the following components are evaluated by the cron trait: `timer`, `cron`, `quartz`. | |||
| // | |||
| // The rules for using a Kubernetes CronJob are the following: | |||
| // - `timer`: when periods can be written as cron expressions. E.g. `timer:tick?period=60000`. | |||
| // | |||
| // - `timer`: when period is set in milliseconds with no remaining seconds, for example 120000. If there is any second left as in 121000 (120s and 1s) or the presence of any of these parameters (delay, repeatCount, time) then a CronJob won't be created, but a standard deployment. | |||
There was a problem hiding this comment.
Just out of curiosity. Where is this behavior defined? in the runtime?
There was a problem hiding this comment.
It is defined partly in the cron.go trait and the camel-k-cron (camel-k-runtime).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix doc related to when the timer is materialized as a CronJOb
Release Note