fix(core): Access configmap from another namespace for KEP-1755 #4849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Oct 24, 2023
squakez
reviewed
Oct 24, 2023
gansheer
force-pushed
the
chore/test_kustomize_integration
branch
2 times, most recently
from
a63ebbf
to
9d12a92
Compare
gansheer
changed the title
squakez
reviewed
Oct 24, 2023
gansheer
force-pushed
the
chore/test_kustomize_integration
branch
from
9d12a92
to
028d7ac
Compare
squakez
approved these changes
Oct 24, 2023
gansheer
force-pushed
the
chore/test_kustomize_integration
branch
3 times, most recently
from
2f23084
to
86b2e95
Compare
|
OLM checks should be fixed now. You can rebase please. |
gansheer
force-pushed
the
chore/test_kustomize_integration
branch
from
86b2e95
to
ed88203
Compare
Done, but I still need to fix some configuration to really test KEP-1755. |
gansheer
force-pushed
the
chore/test_kustomize_integration
branch
2 times, most recently
from
2678586
to
6674d90
Compare
gansheer
force-pushed
the
chore/test_kustomize_integration
branch
4 times, most recently
from
1b9c713
to
59474f0
Compare
gansheer
force-pushed
the
chore/test_kustomize_integration
branch
from
364be0d
to
c411563
Compare
|
All green. Is it ready to merge? |
|
Yes please. |
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #3615
Change kubernetes CLI usage to actually get the configmap
local-registry-hostingin namespacekube-publicfor kind action registry configuration from KEP-1755.Release Note