Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(health): #3997 structured conditions for scaled integrations #4917

Merged
merged 1 commit into from
Nov 20, 2023
Merged

test(health): #3997 structured conditions for scaled integrations #4917

merged 1 commit into from
Nov 20, 2023

Conversation

rinaldodev
Copy link
Contributor

@rinaldodev rinaldodev commented Nov 13, 2023 •
edited
Loading

Fixes #3997

@rinaldodev
Copy link
Contributor Author

@squakez I was considering adding tests for more scenarios. Do you think its worth it?

@squakez
Copy link
Contributor

squakez commented Nov 13, 2023

@squakez I was considering adding tests for more scenarios. Do you think its worth it?

The more scenario we cover the better. However, for the specific issue I think it should be fine.

@squakez
Copy link
Contributor

squakez commented Nov 14, 2023

Feel free to move the PR to ready to review or add a comment when you are okey to merge it.

@rinaldodev
Copy link
Contributor Author

Feel free to move the PR to ready to review or add a comment when you are okey to merge it.

Thanks, I will. Some of the tests are flaky and I'm trying to figure out why.

@rinaldodev rinaldodev marked this pull request as ready for review November 17, 2023 21:14
@rinaldodev
Copy link
Contributor Author

Thanks, I will. Some of the tests are flaky and I'm trying to figure out why.

Some of the original tests are flaky because sometimes routes are considered UP for a while before being reported as DOWN. Since this PR is now open for some time, I'll look for a fix in a different issue/PR.

@squakez squakez merged commit 0c6e0e0 into apache:main Nov 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squakez squakez squakez approved these changes

@oscerd oscerd oscerd approved these changes

@lburgazzoli lburgazzoli lburgazzoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a test for structured health check conditions when integrations are scaled > 1
4 participants
@rinaldodev @squakez @lburgazzoli @oscerd