Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Remove golint warning for imports #4920

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

gansheer
Copy link
Contributor

@gansheer gansheer commented Nov 15, 2023

Add validation on more path code changes

Release Note

NONE

@gansheer
Copy link
Contributor Author

@christophd @squakez Should fix the lint issue from #4919

@gansheer gansheer changed the title Fix(ci): Remove golint warning for imports fix(ci): Remove golint warning for imports Nov 15, 2023
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing the validation from those paths? We should instead fix the code which is not following formatting style IMO.

@squakez
Copy link
Contributor

squakez commented Nov 15, 2023

Why removing the validation from those paths? We should instead fix the code which is not following formatting style IMO.

Forget about this comment, I need a coffe, sorry.

@christophd christophd merged commit ecdda13 into apache:main Nov 15, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants