Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(trait): run mount only when necessary #4926

Merged
merged 1 commit into from
Nov 24, 2023
Merged

chore(trait): run mount only when necessary #4926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/trait/mount.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,11 @@ func (t *mountTrait) Configure(e *Environment) (bool, *TraitCondition, error) {
}
}

// mount trait needs always to be executed as it will process the sources
return true, nil, nil
// mount trait needs to be executed only when it has sources attached or any trait configuration
return len(e.Integration.Sources()) > 0 ||
len(t.Configs) > 0 ||
len(t.Resources) > 0 ||
len(t.Volumes) > 0, nil, nil
}

func (t *mountTrait) Apply(e *Environment) error {
Expand Down
Loading