-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Add sundrio to generate builders #4931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to decline this one. We already discussed with the community the opportunity to use code generators such as Lombok. With a negative answer.
@andreaTP what would be the use case to manipulate Camel K k8s objects ? |
@squakez in this case both Lombok and Sundrio are used only at compile time and are not transitive dependencies for the user. @claudio4j : |
Okey. Maybe, given that this is an auto generated project where user is not meant to manually compile it, we can accept it. @oscerd wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope we can remove lombok even if it's only a runtime dependency.
@andreaTP please, remind to remove the dependencies in the future when no longer necessary. Thanks! |
@oscerd and @squakez I'm not sure about those last comments, both This means that they will be available on the classpath only during compilation and they are not going to be considered transitive dependencies of the resulting artifact.
It's not a runtime dependency and we can't remove it to get the generated builder pattern.
Just to be clear, the only thing I will change over the current configuration is the removal of the explicit |
Our idea is to avoid Lombok as much as we can. Since this is a separated context for generating stuff, that's fine, but we would like to avoid the spreading of Lombok around the codebase. It's provided and that's fine. |
agreed |
Add
sundrio
to generate builder pattern for the model classes of the generated CRD.With the upcoming version of
kubernetes-client-bom-with-deps
we should be able to remove the explicit versions ofsundrio
andlombok
too.