-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experiment] Use Jbang camel k plugin in e2e test #5175
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work! With this approach we can keep kamel
test as well while we keep supporting other CLI and be able to start using camel
in all the run
tests.
|
e2e/support/test_support.go
Outdated
} | ||
} else { | ||
// Use modeline CLI as it's closer to the real usage | ||
c, args, err = cmd.NewKamelWithModelineCommand(ctx, append([]string{"camel", "k"}, args...)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to use the environment variable JBANG_NO_VERSION_CHECK=true
to avoid jbang to check update.
3f4ac75
to
d962621
Compare
c3ab97d
to
72d8f9d
Compare
72d8f9d
to
01eb47e
Compare
@squakez @oscerd @christophd @claudio4j Could the tests be triggered please 🙏 |
c05455e
to
a28d669
Compare
The change to use camel k plugin looks good. |
1c85fe5
to
32474f4
Compare
f78f771
to
d00c4f0
Compare
e088100
to
0b35ba9
Compare
0b35ba9
to
5477ae4
Compare
55dd8a1
to
376acda
Compare
376acda
to
5770529
Compare
Release Note