-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMEL-20888 - Remove Kotlin DSL #5833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kotlin was supported even without the Kotlin DSL and long before the merge of that feature, so it shouldn't be removed from camel k
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oscerd indeed, Kotlin was originally developed as a language supported by the Camel K Runtime dependency only. However, lately we delegate the languages runtime aspects to the core, so, once it will be removed from core, then, it won't work in Camel K either.
@apupier I'd suggest that, before this change we introduce a deprecation notice as we are used to to with any feature we're willing to drop. Later we can remove the code.
@@ -1679,12 +1679,6 @@ spec: | |||
camel-quarkus-knative-producer: | |||
groupId: org.apache.camel.quarkus | |||
artifactId: camel-quarkus-knative-producer | |||
camel-quarkus-kotlin: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The catalog is autogenerated and depends on Camel K Runtime. It should not be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed changes to this file
the deprecation was announced with Camel 4.7 https://camel.apache.org/manual/camel-4x-upgrade-guide-4_7.html#_camel_kotlin_deprecation |
5f8bc7f
to
0b347cc
Compare
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
0b347cc
to
9b68097
Compare
Camel K is default to 4.4. Although the core deprecated this language some time ago, there was no Camel K. user that could have seen this. Next core default version will be likely 4.8. I suggest to add a deprecation notice in the upcoming version (2.5) and remove the feature from the next versions (>= 2.6) onward. |
I have not found a migration documentation or changelog specific to Camel K. Can you point me to the expected place? Kotlin DSL was marked as experimental so I think it can potentially be removed whenever we want. But it is fine to do the extra effort to maintain that in Camel K if it is still based on Camel 4.8 for some time which will contain still the Kotlin DSL. |
raised #5837 as i do not have an environment ready for go development |
Release Note