JAVA-3070: Make CqlVector and CqlDuration serializable #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhughes
commented
Jul 11, 2023
core/src/main/java/com/datastax/oss/driver/api/core/data/CqlVector.java
Outdated
Show resolved
Hide resolved
absurdfarce
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Reviewed in a call with @hhughes. Changes seem pretty robust; I very much like the fact that we aren't relying on both sides having the concrete List implementation for CqlVectors built from some random List impl.
hhughes
force-pushed
the
JAVA-3070
branch
2 times, most recently
from
57acc48
to
e3feb46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.