-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copyright to ASF #1682
Copyright to ASF #1682
Conversation
8c220ba
to
e705036
Compare
e705036
to
1f030bc
Compare
If you want to look at any changes which aren't to .java files |
I notice in the new license we're using There are a few places where we use various different symbles after the name if we should be tidying those up at the same time:
|
Github review UI is unusable for me with this patch :) I'm going to add feeback as main comments
|
There are still a few matches for otherly cased
|
should be Apache Cassandra® on the first usage on any page. but this is not critical. (can be addressed later on.)
on it… |
1f030bc
to
85e89eb
Compare
All branches done. |
85e89eb
to
c7479c7
Compare
Nit: the license in |
no concern |
Nit: one mention of |
Python-script for filtering out common license change hunks from the diff: license_change_diff_filter.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One remaining question about DataStax branding in SingleFileCodeGenerator.java
, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving this one
All merged. |
see https://incubator.apache.org/ip-clearance/cassandra-java-driver.html