Skip to content

Commit

Permalink
[CELEBORN-1384] Manually excluding workers should not depend on wheth…
Browse files Browse the repository at this point in the history
…er the workers are alive

### What changes were proposed in this pull request?

Manually excluding workers should not depend on whether the workers are alive or not for master.

### Why are the changes needed?

When the workers are offline, master could not add or remove workers through manually excluding workers. Therefore, master should support manually excluding workers no matter whether the workers are alive or not.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manual test.

Closes #2465 from SteNicholas/CELEBORN-1384.

Authored-by: SteNicholas <programgeek@163.com>
Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
  • Loading branch information
SteNicholas authored and RexXiong committed Apr 18, 2024
1 parent 8c65ddd commit 2c76a6e
Showing 1 changed file with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -684,10 +684,7 @@ private[celeborn] class Master(
workersToAdd: util.List[WorkerInfo],
workersToRemove: util.List[WorkerInfo],
requestId: String): Unit = {
statusSystem.handleWorkerExclude(
workersToAdd.asScala.filter(workersSnapShot.contains(_)).asJava,
workersToRemove.asScala.filter(workersSnapShot.contains(_)).asJava,
requestId)
statusSystem.handleWorkerExclude(workersToAdd, workersToRemove, requestId)
if (context != null) {
context.reply(WorkerExcludeResponse(true))
}
Expand Down

0 comments on commit 2c76a6e

Please sign in to comment.