Skip to content

Commit

Permalink
[CELEBORN-1783][FOLLOWUP][0.4] Compatible with UT
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

Compatible with UT for branch-0.4, followup de436f7

### Why are the changes needed?

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

Closes #3024 from turboFei/branch-0.4_ut.

Authored-by: Wang, Fei <fwang12@ebay.com>
Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
  • Loading branch information
turboFei authored and RexXiong committed Dec 24, 2024
1 parent c6855e6 commit 5494cf7
Showing 1 changed file with 9 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,16 @@ class LifecycleManagerCommitFilesSuite extends WithShuffleClientSuite with MiniC
}
celebornConf
.set(CelebornConf.CLIENT_PUSH_REPLICATE_ENABLED.key, "false")
val masterConf = Map(
"celeborn.master.host" -> "localhost",
"celeborn.master.port" -> masterPort.toString,
"celeborn.master.endpoints" -> s"localhost:$masterPort")
val workerConf0 = Map(
s"${CelebornConf.WORKER_SHUFFLE_COMMIT_TIMEOUT.key}" -> "100",
s"${CelebornConf.WORKER_COMMIT_THREADS.key}" -> "1",
s"${CelebornConf.TEST_MOCK_COMMIT_FILES_FAILURE.key}" -> "true")
val (master, _) = setupMiniClusterWithRandomPorts(workerConf = workerConf0)
s"${CelebornConf.TEST_MOCK_COMMIT_FILES_FAILURE.key}" -> "true",
"celeborn.master.endpoints" -> s"localhost:$masterPort")
val (master, _) = setUpMiniCluster(masterConf = masterConf, workerConf = workerConf0)
celebornConf.set(
CelebornConf.MASTER_ENDPOINTS.key,
master.conf.get(CelebornConf.MASTER_ENDPOINTS.key))
Expand All @@ -176,7 +181,7 @@ class LifecycleManagerCommitFilesSuite extends WithShuffleClientSuite with MiniC
assert(res.status == StatusCode.SUCCESS)

lifecycleManager.setupEndpoints(
res.workerResource.keySet(),
res.workerResource,
shuffleId,
new ShuffleFailedWorkers())

Expand All @@ -186,7 +191,7 @@ class LifecycleManagerCommitFilesSuite extends WithShuffleClientSuite with MiniC
res.workerResource,
updateEpoch = false)

lifecycleManager.commitManager.registerShuffle(shuffleId, 1, false)
lifecycleManager.commitManager.registerShuffle(shuffleId, 1)
0 until 1000 foreach { partitionId =>
lifecycleManager.commitManager.finishMapperAttempt(shuffleId, 0, 0, 1, partitionId)
}
Expand Down

0 comments on commit 5494cf7

Please sign in to comment.