Skip to content

Commit

Permalink
[CELEBORN-1230] Check working directory read and write error without …
Browse files Browse the repository at this point in the history
…init delay

### What changes were proposed in this pull request?
In this pr, when getting device disk info, we check the dir writable to make sure that the capacity reported to celeborn master are correct and does no include non-writable directories.
### Why are the changes needed?
To ignore bad disk when initializing the worker.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?

Existing UT.

Closes #2233 from turboFei/check_disk_init.

Lead-authored-by: Fei Wang <fwang12@ebay.com>
Co-authored-by: Keyong Zhou <zky.zhoukeyong@alibaba-inc.com>
Signed-off-by: zky.zhoukeyong <zky.zhoukeyong@alibaba-inc.com>
  • Loading branch information
turboFei and waitinfuture committed Feb 15, 2024
1 parent c183753 commit e54a2b7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ class LocalDeviceMonitor(
}
}
},
diskCheckInterval,
0,
diskCheckInterval,
TimeUnit.MILLISECONDS)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ class WorkerSuite extends AnyFunSuite with BeforeAndAfterEach {

override def beforeEach(): Unit = {
assert(null == worker)
conf.set(s"${CelebornConf.WORKER_DISK_MONITOR_CHECKLIST.key}", "readwrite")
}

override def afterEach(): Unit = {
Expand Down

0 comments on commit e54a2b7

Please sign in to comment.