[CELEBORN-1052][FOLLOWUP] Introduce dynamic ConfigService at SystemLevel and TenantLevel #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2125 +/- ##
==========================================
+ Coverage 47.13% 47.21% +0.08%
==========================================
Files 173 173
Lines 11034 11039 +5
Branches 1011 1011
==========================================
+ Hits 5200 5211 +11
+ Misses 5494 5486 -8
- Partials 340 342 +2 ☔ View full report in Codecov by Sentry. |
…vel and TenantLevel
SteNicholas
force-pushed
the
CELEBORN-1052
branch
from
5a727be
to
d344966
Compare
|
why do moving files produce lots of code style changes? |
|
@pan3793, the implementation of |
alright, put such information to "Why are the changes needed?" |
|
@pan3793, thanks for the reminder. I have updated |
pan3793
reviewed
Dec 1, 2023
service/src/main/java/org/apache/celeborn/server/common/service/config/FsConfigServiceImpl.java
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/config/ConfigService.java
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Dec 1, 2023
service/src/main/java/org/apache/celeborn/server/common/service/config/FsConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Dec 1, 2023
service/src/main/java/org/apache/celeborn/server/common/service/config/FsConfigServiceImpl.java
Show resolved
Hide resolved
RexXiong
reviewed
Dec 2, 2023
service/src/main/java/org/apache/celeborn/server/common/service/config/ConfigService.java
Outdated
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/config/FsConfigServiceImpl.java
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/config/FsConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
…vel and TenantLevel
pan3793
approved these changes
Dec 4, 2023
…vel and TenantLevel
RexXiong
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow up #2100. Mainly changes the package from scala to java of the codes in #2100. Meanwhile,
FsConfigServiceImpl#refreshshould directly return instead of refreshing configs.Why are the changes needed?
This PR follow up dynamic
ConfigServiceatSystemLevelandTenantLevel, Dynamic configuration is a type of configuration that can be changed at runtime as needed in #2100. The implementation ofConfigServiceis based on Java codes, which are put into Scala package and cause that the spotless plugin does not format well. After the changes of the pull request, there are much code style changes generated from the package moving behavior.Does this PR introduce any user-facing change?
No.
How was this patch tested?
ConfigServiceSuiteJ.