[CELEBORN-1264] ConfigService supports TENANT_USER config level #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @SteNicholas @RexXiong cc @leixm |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2285 +/- ##
==========================================
+ Coverage 48.85% 48.93% +0.09%
==========================================
Files 208 208
Lines 12837 12893 +56
Branches 1104 1113 +9
==========================================
+ Hits 6270 6308 +38
- Misses 6167 6176 +9
- Partials 400 409 +9 ☔ View full report in Codecov by Sentry. |
SteNicholas
reviewed
Feb 4, 2024
service/src/main/java/org/apache/celeborn/server/common/service/config/ConfigLevel.java
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/config/ConfigService.java
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Feb 4, 2024
SteNicholas
reviewed
Feb 4, 2024
service/src/main/java/org/apache/celeborn/server/common/service/config/ConfigService.java
Outdated
Show resolved
Hide resolved
RexXiong
reviewed
Feb 5, 2024
service/src/main/java/org/apache/celeborn/server/common/service/config/ConfigLevel.java
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/config/ConfigService.java
Outdated
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/config/UserConfig.java
Outdated
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/config/ConfigService.java
Outdated
Show resolved
Hide resolved
|
@AngersZhuuuu ConfigService has been refined, pls resolve the conflict, refer: #2273 |
|
@RexXiong @SteNicholas Pls take a look again, have changed base on new code. |
AngersZhuuuu
changed the title
RexXiong
reviewed
Feb 6, 2024
service/src/main/java/org/apache/celeborn/server/common/service/config/FsConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/config/FsConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Feb 6, 2024
service/src/main/java/org/apache/celeborn/server/common/service/config/FsConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Feb 6, 2024
service/src/main/java/org/apache/celeborn/server/common/service/config/ConfigService.java
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/config/ConfigService.java
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/store/IServiceManager.java
Show resolved
Hide resolved
...e/src/main/java/org/apache/celeborn/server/common/service/store/db/DbServiceManagerImpl.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/celeborn/server/common/service/store/db/DbServiceManagerImpl.java
Outdated
Show resolved
Hide resolved
|
@AngersZhuuuu, could you add description about introduced interfaces in |
AngersZhuuuu
changed the title
SteNicholas
reviewed
Feb 18, 2024
service/src/main/java/org/apache/celeborn/server/common/service/config/FsConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/config/FsConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
SteNicholas
changed the title
SteNicholas
reviewed
Feb 18, 2024
SteNicholas
changed the title
SteNicholas
approved these changes
Feb 18, 2024
SteNicholas
approved these changes
Feb 18, 2024
|
Merge to master branch, thanks |
tiny-dust
pushed a commit
to tiny-dust/incubator-celeborn
that referenced
this pull request
Feb 20, 2024
### What changes were proposed in this pull request? ConfigService support user level config ### Why are the changes needed? Support more case of config, later can integrate with quota manager ### Does this PR introduce _any_ user-facing change? With this pr, user's setting form config service will have three level - User - Tenant - System User identifier is construct by username and tenantId, If there is no specify setting for username, will fallback to tenant level setting, if tenant level setting also not set, fallback to system setting ### How was this patch tested? Added UT Closes apache#2285 from AngersZhuuuu/CELEBORN-1264. Authored-by: Angerszhuuuu <angers.zhu@gmail.com> Signed-off-by: Angerszhuuuu <angers.zhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ConfigService support user level config
Why are the changes needed?
Support more case of config, later can integrate with quota manager
Does this PR introduce any user-facing change?
With this pr, user's setting form config service will have three level
User identifier is construct by username and tenantId,
If there is no specify setting for username, will fallback to tenant level setting, if tenant level setting also not set, fallback to system setting
How was this patch tested?
Added UT