-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CELEBORN-1368] Log celeborn config for debugging purposes #2442
Conversation
cc @waitinfuture @SteNicholas @FMX can you guys please take a look? thanks. |
@akpatnam25, why does this need to log celeborn config? Could user use |
We do not have the REST api changes internally yet, as we are running with 0.4 still. This would unblock us quick, in the long term I agree we should use the /conf REST API. I will use the |
Hi @akpatnam25 , please run |
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala
Show resolved
Hide resolved
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala
Show resolved
Hide resolved
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR can be changed.
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala
Show resolved
Hide resolved
@SteNicholas @pan3793 @FMX @waitinfuture I have updated this PR. please take another look, thanks |
@akpatnam25 There is a compilation error that needs to be fixed first. |
I accidentally deleted a line! Should be fixed now. @FMX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks. Merged into main(v0.5.0).
thanks for the reviews @SteNicholas @FMX @pan3793 @waitinfuture !! |
What changes were proposed in this pull request?
Log celeborn config for debugging purposes.
Why are the changes needed?
Help with debugging
Does this PR introduce any user-facing change?
No
How was this patch tested?
tested the patch internally.