[CELEBORN-1356] Split rpc module into rpc_app and rpc_service #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it makes it easier to review, I can split it into two - updates to |
|
The test failure seems to be some timeout issue ? this is ready for review. +CC @otterc , @waitinfuture, @FMX , @pan3793 |
FMX
reviewed
Apr 17, 2024
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Apr 17, 2024
common/src/main/java/org/apache/celeborn/common/protocol/TransportModuleConstants.java
Outdated
Show resolved
Hide resolved
pan3793
changed the title
|
code change lgtm, could you pls add an item to the migration guide? |
pan3793
approved these changes
Apr 17, 2024
I was planning to add that as part of https://issues.apache.org/jira/browse/CELEBORN-1353 .. should I be adding it as part of this PR instead ? Edit: added a note in CELEBORN-1353 on migration guide |
|
@mridulm thanks for opening a dedicated ticket for docs, merged to main for 0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Split the
rpctransport module intorpc_appandrpc_serviceto allow for them to be independently configured.Why are the changes needed?
We need the ability to independently configure communication between application components (driver/executors in spark applications) and those to/from Celeborn service (master/workers) components.
This is particularly relevant for TLS support where applications might be running with TLS disabled for their rpc services or using self-signed certificates (see CELEBORN-1354 for an example), while services would have signed certs.
Does this PR introduce any user-facing change?
Yes, it allows users to independently configure rpc env within the application and those to/from services.
Backward compatibility is maintained - and so existing
rpcis the fallback in caserpc_apporrpc_serviceconfig is not found.How was this patch tested?
Unit tests were enhanced, existing tests pass.