Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1504][FOLLOWUP] Start test nodes in random ports to allow multiple builds run in the same ci server #2902

Closed
wants to merge 1 commit into from

Conversation

SteNicholas
Copy link
Member

What changes were proposed in this pull request?

Start test nodes in random ports to allow multiple builds run in the same ci server, which improves the test implementations so that it starts test nodes in random ports instead of using the hardcoded ones.

Follow up #2619.

Why are the changes needed?

The test nodes are started in the hard coded ports, this prevents to run multiple builds in the same CI/CD server at present.

Bump the changes of #2237.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

RemoteShuffleMasterSuiteJ

@SteNicholas
Copy link
Member Author

@turboFei, #2901 should also change the flink-1.16 module.

Ping @mridulm, @reswqa.

Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@FMX FMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Merged into main(v0.6.0)

@FMX FMX closed this in 8b54ed8 Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants