Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor docs update for multiple local storage pools for KVM #359

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Minor docs update for multiple local storage pools for KVM #359

merged 3 commits into from
Jan 17, 2024

Conversation

andrijapanicsb
Copy link
Contributor

@andrijapanicsb andrijapanicsb commented Dec 1, 2023 •
edited by github-actions bot
Loading

minor details updated, for easier configuration and better search results (multiple local storages AND multiple local storage pools)

📚 Documentation preview 📚: https://cloudstack-documentation--359.org.readthedocs.build/en/359/

@andrijapanicsb
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@andrijapanicsb a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@weizhouapache
Copy link
Member

@blueorangutan docbuild

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@shwstppr shwstppr added this to the 4.19 milestone Dec 1, 2023
@rohityadavcloud
Copy link
Member

Let me try again

@blueorangutan docbuild

@blueorangutan
Copy link

@rohityadavcloud a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@weizhouapache weizhouapache reopened this Dec 5, 2023
@shwstppr
Copy link
Contributor

shwstppr commented Dec 6, 2023

@blueorangutan docbuild

shwstppr
shwstppr approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shwstppr shwstppr requested a review from DaanHoogland December 6, 2023 12:23
@andrijapanicsb
Copy link
Contributor Author

There is a new UI feature that makes adding Local pools via UI - much easier...
Need to update docs for this as well... 2 ways now to add local pool..,.

Please don't merge, I will update, evetnually...

@DaanHoogland
Copy link
Contributor

Please don't merge, I will update, evetnually...

marking as draft

@DaanHoogland DaanHoogland marked this pull request as draft December 6, 2023 14:52
@shwstppr
Copy link
Contributor

@andrijapanicsb is this needed with #366?

@andrijapanicsb
Copy link
Contributor Author

Yes, needed.

@shwstppr shwstppr marked this pull request as ready for review January 12, 2024 12:09
@shwstppr
Copy link
Contributor

@weizhouapache @DaanHoogland can you please review?

@apache apache deleted a comment from blueorangutan Jan 16, 2024
@shwstppr
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/359. (QA-JID 191)

@DaanHoogland DaanHoogland merged commit 9c0473e into main Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland left review comments

@shwstppr shwstppr shwstppr approved these changes

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.19
Development

Successfully merging this pull request may close these issues.
6 participants
@andrijapanicsb @blueorangutan @weizhouapache @rohityadavcloud @shwstppr @DaanHoogland