-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IPv6 Support page to remove explanation of what an IPv6 address is from introduction #370
Conversation
@mivsvit do you think we need to add a warning not to use the example (ever)? |
I think better to remove most of that paragraph and just say as an introduction "CloudStack supports IPv6 for shared and isolated networks. It also supports IPv6 for VPC tiers." and leave it at that. Given the technical level of the content on that page I would suggest it is fair to assume the reader should know already what an IPv6 address is. There are already examples of IPv6 CIDRs as appropriate later on that page. And other parts of that introduction are not great - for example, although IPv6 has been slow to be adopted, it's been around for decades, it is not "recent" and it is not a good definition of IP that it "defines routing the network traffic". |
sounds good, would you extend your PR for this, @mivsvit ? |
Remove some of the introduction which contained an explanation of what an IPv6 address is.
@alexandremattioli would you agree? |
Co-authored-by: dahn <daan.hoogland@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The characters
s
andt
are not valid hex.Correct the example
5001:0dt8:83a3:1012:1000:8s2e:0870:7454
so that it is a valid IPv6 address.Also change to use the 2001:db8::/32 IPv6 documentation prefix.
📚 Documentation preview 📚: https://cloudstack-documentation--370.org.readthedocs.build/en/370/