Skip to content

Change the value parameter of the updateConfiguration API to be required #10790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: 4.22
Choose a base branch
from
+4 −4
Open

Change the value parameter of the updateConfiguration API to be required #10790

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eab86b9
make value parameter of the updateConfiguration API required
bernardodemarco Apr 29, 2025
8cfc5eb
clean up config values
bernardodemarco Apr 30, 2025
373df59
remove unecessary validation
bernardodemarco Apr 30, 2025
37a8321
fix test_vm_strict_host_tags.py integration tests
bernardodemarco Jun 6, 2025
696cd1d
fix test_global_settings.py integration tests
bernardodemarco Jun 6, 2025
7b5a14d
fix test_deploy_vm_extra_config_data.py integration tests
bernardodemarco Jun 6, 2025
2d7e0c2
trying new approach
bernardodemarco Oct 31, 2025
2deab67
Update server/src/main/java/com/cloud/configuration/ConfigurationMana…
bernardodemarco Nov 5, 2025
fb158ea
Update server/src/main/java/com/cloud/configuration/ConfigurationMana…
bernardodemarco Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,6 +1030,10 @@ public Configuration updateConfiguration(final UpdateCfgCmd cmd) throws InvalidP
category = config.getCategory();
}

if (value == null) {
throw new InvalidParameterValueException(String.format("The new value for the [%s] configuration must be given.", name));
}

validateIpAddressRelatedConfigValues(name, value);
validateConflictingConfigValue(name, value);

Expand All @@ -1038,10 +1042,6 @@ public Configuration updateConfiguration(final UpdateCfgCmd cmd) throws InvalidP
throw new CloudRuntimeException("Only Root Admin is allowed to edit this configuration.");
}

if (value == null) {
return _configDao.findByName(name);
}

ConfigKey.Scope scope = null;
Long id = null;
int paramCountCheck = 0;
Expand Down
Loading