Skip to content

Conversation

Pearl1594
Copy link
Contributor

Description

This PR fixes: #8165

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@Pearl1594 Pearl1594 changed the title Veeam: Use restore timeout as a time interval as opposed to a counter Veeam: Use restore timeout as an interval as opposed to a counter Oct 1, 2025
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.61%. Comparing base (cd12fa5) to head (cd63800).
⚠️ Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (cd12fa5) and HEAD (cd63800). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (cd12fa5) HEAD (cd63800)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               main   #11772       +/-   ##
=============================================
- Coverage     17.50%    3.61%   -13.90%     
=============================================
  Files          5894      442     -5452     
  Lines        526877    37255   -489622     
  Branches      64337     6836    -57501     
=============================================
- Hits          92232     1345    -90887     
+ Misses       424269    35747   -388522     
+ Partials      10376      163    -10213     
Flag Coverage Δ
uitests 3.61% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harikrishna-patnala harikrishna-patnala added this to the 4.22.0 milestone Oct 2, 2025
@DaanHoogland DaanHoogland reopened this Oct 3, 2025
Comment on lines +385 to +386
logger.debug(String.format("Waiting %d seconds, out of a total of %d seconds, for the restore backup process to finish.",
(System.currentTimeMillis() - startTime) / 1000, restoreTimeout));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logger.debug(String.format("Waiting %d seconds, out of a total of %d seconds, for the restore backup process to finish.",
(System.currentTimeMillis() - startTime) / 1000, restoreTimeout));
logger.debug("Waiting {} seconds, out of a total of {} seconds, for the restore backup process to finish.",
() -> (System.currentTimeMillis() - startTime) / 1000, restoreTimeout);

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15271

@DaanHoogland
Copy link
Contributor

seems like the unit test needs an update as well:

https://github.com/apache/cloudstack/actions/runs/18215826235/job/51864745203?pr=11772#step:7:22893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restoreTimeout in VeeamClient is being used as a counter
4 participants