-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Veeam: Use restore timeout as an interval as opposed to a counter #11772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #11772 +/- ##
=============================================
- Coverage 17.50% 3.61% -13.90%
=============================================
Files 5894 442 -5452
Lines 526877 37255 -489622
Branches 64337 6836 -57501
=============================================
- Hits 92232 1345 -90887
+ Misses 424269 35747 -388522
+ Partials 10376 163 -10213
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
logger.debug(String.format("Waiting %d seconds, out of a total of %d seconds, for the restore backup process to finish.", | ||
(System.currentTimeMillis() - startTime) / 1000, restoreTimeout)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logger.debug(String.format("Waiting %d seconds, out of a total of %d seconds, for the restore backup process to finish.", | |
(System.currentTimeMillis() - startTime) / 1000, restoreTimeout)); | |
logger.debug("Waiting {} seconds, out of a total of {} seconds, for the restore backup process to finish.", | |
() -> (System.currentTimeMillis() - startTime) / 1000, restoreTimeout); |
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15271 |
seems like the unit test needs an update as well: https://github.com/apache/cloudstack/actions/runs/18215826235/job/51864745203?pr=11772#step:7:22893 |
Description
This PR fixes: #8165
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?