Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend getFullPathNoEndSeparator description for trailing slash home path behaviour #551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Philzen
Copy link

@Philzen Philzen commented Jan 4, 2024

The description says it will remove the trailing slash from a home path (relative path starting with tilde).

A simple

        @Test void returnsHomeWithTrailingSlash_forHomeWithTrailingSlash() {
            assertThat(FilenameUtils.getFullPathNoEndSeparator("~/")).isEqualTo("~/");
        }

proves otherwise.

This fixes the description accordingly. NB: this behaviour has been existent since 2.4, where i discovered it.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case I think the existing behavior and the changed docs are correct.

@Philzen
Copy link
Author

Philzen commented Apr 24, 2024

Any objections merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants