Skip to content

LANG-1769 - FastDateFormat#1395

Closed
trungpnt-byte wants to merge 1 commit intoapache:masterfrom
trungpnt-byte:LANG-1769-FastDateFormat
Closed

LANG-1769 - FastDateFormat#1395
trungpnt-byte wants to merge 1 commit intoapache:masterfrom
trungpnt-byte:LANG-1769-FastDateFormat

Conversation

@trungpnt-byte
Copy link
Copy Markdown

@trungpnt-byte trungpnt-byte commented Jun 2, 2025

Thanks for your contribution to Apache Commons! Your help is appreciated!

A proposed fix for https://issues.apache.org/jira/browse/LANG-1769

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.

Signed-off-by: trungpnt-byte <metopsecret9999@gmail.com>
@ppkarwasz
Copy link
Copy Markdown
Contributor

@trungpnt-byte,

Thank you for your contribution!

  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.

Could you please expand the pull request description to clearly explain the changes you're proposing in FastDateFormat? Currently, it only references LANG-1769], but it doesn’t provide much detail on what the fix is or how it addresses the issue. A clearer summary would help reviewers understand the context and purpose of the change more easily.

  • Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.

Could you also amend the commit message to include a short, descriptive title summarizing the change? Right now, it only refers to the JIRA issue number, which doesn't give much insight into the nature of the fix. A more informative commit title will improve readability and traceability in the project commit history.

Note: In the current form I am unwilling to accept this PR, since it breaks compatibility between SimpleDateParser and FastDateParser. See the comment I left in LANG-1769 for a way to maintain backward compatibility and enhance FastDateParser to support strict validation of dates.

@garydgregory
Copy link
Copy Markdown
Member

Closing: No reply in the last 2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants