-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
In the intial implementation of $beginsWith, the range calculation for view indexes mistakenly appends an integer with the size of 8 bits which gets maxed out at FF, rather than building a binary with an extra 3 bytes at the end. Additionally, ICU defines the maximum sortable code point as `U+FFFF`. This is a more correct suffix when calculating the key range and is supported by older ICU versions (required for e.g. CentOS 7). This commit fixes the range calculation by correctly appending the `U+FFFF` code point in the range calculation. Additionally, we use the Erlang `utf8` binary type to verify that the result is a valid utf8 string.
- Loading branch information
1 parent
e9d703c
commit 5296a02
Showing
2 changed files
with
6 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters