Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(configure): be more defensive about SpiderMonkey location #4380

Merged
merged 3 commits into from
Jan 26, 2023
Merged

chore(configure): be more defensive about SpiderMonkey location #4380

merged 3 commits into from
Jan 26, 2023

Commits on Jan 26, 2023

  1. chore(configure): be more defensive about SpiderMonkey location 

    The `configure` script does not check whether SpiderMonkey
actually exists at the presumed location.  This may go wrong when
the user has a version different from the default one.  The
mistake is spotted only in build time, indirectly, via missing
header files.  That is too late and it may not be evident for the
user what the problem is.

Add a user-friendly safeguard for Unix-like systems to prevent
this from happening.
    @pgj
    pgj committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    12cf4d4 View commit details
    Browse the repository at this point in the history

  2. Unify style of if blocks

    @pgj
    pgj committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    b187cc2 View commit details
    Browse the repository at this point in the history

  3. Port the SpiderMonkey check to Windows

    @pgj
    pgj committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    0ab748a View commit details
    Browse the repository at this point in the history