Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per document access control #4673
base: main
Are you sure you want to change the base?
Per document access control #4673
Changes from 61 commits
11302dd
3d225cc
d182a9c
973c407
3231b08
10525e9
5cb4b09
a76a1a9
033683b
698f268
8a0d901
eb2f0e4
26e6c78
db803af
12abedf
0109b04
6cc46f4
c4f51b7
66bbefa
6fd27aa
c105296
1bb8f00
0a43ca9
afc4aaa
88e7a90
99d1945
70e3934
bd643de
0005e36
b9b057c
fdfa229
f7747d7
f258df4
a97c7d7
ad41b24
82eb860
0f6e2f7
66fdc2a
16680e7
e96415a
7f46c70
2b53bce
441dc28
8ec3a0e
f8586a8
f6e409f
5bc6d1b
88dd94a
3db3dde
c3cdc60
fa31ba9
c76b511
f3a0110
42638d6
6cec6b6
b6b61a0
92dc3d1
fae4a03
d0eecff
6d1d1fa
072d467
b1c6308
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is too generic for me,
per_doc_access_denied
or something similarly descriptive please.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
doc_info
this passed between nodes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is a 5 second timeout appropriate here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it probably needs to be configurable like other query server timeouts