Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INSTALL.Unix: update libmozjs install tips #5107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion INSTALL.Unix.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ You can install the dependencies by running:
build-essential pkg-config erlang erlang-reltool \
libicu-dev libmozjs-60-dev python3

Your distribution may have `libmozjs-68-dev` instead of 60. Both are supported.
Your distribution may have `libmozjs-68-dev` instead of 60. Both are supported. Newer versions of `libmozjs-...-dev` may also work; you can find which are available using `apt-cache search libmozjs`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest mention Newer versions less or equal to 91 of libmozjs... just to be a bit more explicit.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest this, which is i think a bit more comprehensive approach.
Your distribution might provide libmozjs-68-dev instead of libmozjs-60-dev, and both are supported. Additionally, newer versions of libmozjs-...-dev may also be compatible. To see which versions are available, use the command "apt-cache search libmozjs"


You can install Node.JS [NodeSource](https://github.com/nodesource/distributions#installation-instructions).

Expand Down