-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CURATOR-699. Upgrade ZooKeeper version to 3.9 #496
Conversation
Signed-off-by: tison <wander4096@gmail.com>
ByteBuffer duplicate = si.request.duplicate(); | ||
duplicate.rewind(); | ||
ByteBufferInputStream.byteBuffer2Record(duplicate, createRequest); | ||
CreateRequest createRequest = si.readRequestRecord(CreateRequest::new); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may cause failures on early ZK versions and we need a testing compatible layer.
Let the CI verify if it's the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. It fails.
Let me think if we should drop support <= 3.7 or add a test compatible switch.
I think that it is fine to drop support for 3.7 in those tests |
Make sense. I understand it as introducing a new test tag said |
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
It seems because we relocate these methods in curator-framework but not for the test-jar. I don't find a way to relocate the test jar now .. |
I create a monkey patch to work around it - c44e798 |
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Signed-off-by: tison <wander4096@gmail.com>
@eolivelli Thanks for your review. I make this patch work now. Let me create the ticket and a few follow-ups to improve the case (It now takes 2 hours to complete, I believe we can drop a few versions, but better with a few separate tickets). |
No description provided.