CXF-8457 Provide OpenTelemetry support #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mederel
force-pushed
the
opentelemetry
branch
3 times, most recently
from
f72c483
to
6a1b42a
Compare
|
Thanks @mederel for the contribution, to help you with question a bit
It is fine to add CXF deps to BOM (but not external deps like OTEL etc) |
mederel
force-pushed
the
opentelemetry
branch
2 times, most recently
from
8edbccb
to
44aea77
Compare
reta
reviewed
Jul 23, 2023
distribution/src/main/release/samples/jax_rs/tracing_opentelemetry/pom.xml
Outdated
Show resolved
Hide resolved
reta
reviewed
Jul 23, 2023
distribution/src/main/release/samples/jax_rs/tracing_opentelemetry/pom.xml
Show resolved
Hide resolved
reta
reviewed
Jul 23, 2023
...mples/jax_rs/tracing_opentelemetry/src/main/java/demo/jaxrs/tracing/ConsoleSpanExporter.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Jul 23, 2023
.../src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryClientProvider.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Jul 23, 2023
...g-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/OpenTelemetryFeature.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Jul 23, 2023
reta
reviewed
Jul 27, 2023
...entelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/OpenTelemetryTracerUtils.java
Outdated
Show resolved
Hide resolved
reta
approved these changes
Jul 28, 2023
reta
reviewed
Jul 29, 2023
...s/tracing/src/test/java/org/apache/cxf/systest/jaxrs/tracing/opentelemetry/HasAttribute.java
Outdated
Show resolved
Hide resolved
A new module under integration/tracing is introduced to add support for tracing with OpenTelemetry (short OTel). A few additional changes have been done: * Add the OTel BOMs in the parent/pom.xml dependency management (too much? should keep only the dependencies that are used?) * The new module is strongly inspired by the integration/tracing/tracing-opentracing module * The tracing systest was enriched with tests dedicated to OpenTelemetry in the JaxRS and JaxWS contexts * The necessary OTel dependencies are added to distribution/javadoc to be able to produce the documentation * A new Jax-RS sample showcases span creation on client call and server call
|
Thanks a lot @mederel ! |
reta
pushed a commit
that referenced
this pull request
Aug 3, 2023
A new module under integration/tracing is introduced to add support for tracing with OpenTelemetry (short OTel). A few additional changes have been done: * Add the OTel BOMs in the parent/pom.xml dependency management (too much? should keep only the dependencies that are used?) * The new module is strongly inspired by the integration/tracing/tracing-opentracing module * The tracing systest was enriched with tests dedicated to OpenTelemetry in the JaxRS and JaxWS contexts * The necessary OTel dependencies are added to distribution/javadoc to be able to produce the documentation * A new Jax-RS sample showcases span creation on client call and server call
reta
pushed a commit
that referenced
this pull request
Aug 7, 2023
A new module under integration/tracing is introduced to add support for tracing with OpenTelemetry (short OTel). A few additional changes have been done: * Add the OTel BOMs in the parent/pom.xml dependency management (too much? should keep only the dependencies that are used?) * The new module is strongly inspired by the integration/tracing/tracing-opentracing module * The tracing systest was enriched with tests dedicated to OpenTelemetry in the JaxRS and JaxWS contexts * The necessary OTel dependencies are added to distribution/javadoc to be able to produce the documentation * A new Jax-RS sample showcases span creation on client call and server call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new module under integration/tracing is introduced to add support for tracing with OpenTelemetry (short OTel).
A few additional changes have been done: