CXF-8936 Fix h2 protocol negotiation in Jetty Transport #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huw0
changed the title
huw0
changed the title
huw0
changed the title
huw0
force-pushed
the
jetty-transport-connectionfactory-ordering
branch
3 times, most recently
from
32f4d30
to
e1d0f88
Compare
reta
reviewed
Oct 1, 2023
...orts/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/JettyHTTPServerEngine.java
Outdated
Show resolved
Hide resolved
…t so that clients can negotiate h2
huw0
force-pushed
the
jetty-transport-connectionfactory-ordering
branch
from
e1d0f88
to
04dba00
Compare
reta
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have been trying to update one of our apps using the Jetty backend to use http2. While doing this I've noticed that the protocol negotiation is in the wrong order which results in http/1.1 always being preferred where the client includes this in the ALPN handshake. This means that both browsers and cURL will never successfully negotiate h2/http2.
https://issues.apache.org/jira/browse/CXF-8936
output-jetty-original.txt
output-netty.txt