Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jaxb runtime to 4.0.5 #2031

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Upgrade jaxb runtime to 4.0.5 #2031

merged 1 commit into from
Aug 29, 2024

Conversation

jimma
Copy link
Contributor

@jimma jimma commented Aug 28, 2024

No description provided.

@reta
Copy link
Member

reta commented Aug 28, 2024

I believe we have an issue with 4.0.5 :( , apache/cxf-xjc-utils#135

@jimma
Copy link
Contributor Author

jimma commented Aug 28, 2024

It seems it's some javadoc wrong expectation issue in apache/cxf-xjc-utils#135. Can we simply fix the JavadocPluginTest ?

ERROR] Tests run: 8, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.933 s <<< FAILURE! -- in org.apache.cxf.xjc.javadoc.JavadocPluginTest
[ERROR] org.apache.cxf.xjc.javadoc.JavadocPluginTest.testDocumentationOnPropertiesIsOverwrittenByJAXBBindings -- Time elapsed: 0.071 s <<< FAILURE!
java.lang.AssertionError:

Expected: not javadoc contains given comment: Some documentation of element
     but: was </**
 * Documentation from JAXB binding customization Some documentation of element
 */
>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:964)
	at org.junit.Assert.assertThat(Assert.java:930)
	at org.apache.cxf.xjc.javadoc.JavadocPluginTest.testDocumentationOnPropertiesIsOverwrittenByJAXBBindings(JavadocPluginTest.java:127)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)

@reta
Copy link
Member

reta commented Aug 28, 2024

It seems it's some javadoc wrong expectation issue in apache/cxf-xjc-utils#135. Can we simply fix the JavadocPluginTest ?

Correct, I briefly looked at the test case before, it expects some overrides to be respected, that was working fine pre-4.0.5 but breaks with new version. I will try to take a look shortly, thanks @jimma !

@reta
Copy link
Member

reta commented Aug 28, 2024

I think we should be good to go, I pinpointed the change in question and merged apache/cxf-xjc-utils#135, thanks @jimma !

@reta reta merged commit 8ae1a24 into apache:main Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants