CXF-7396: CachedOutputStream doesn't delete temp files #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
force-pushed
the
CXF-7396
branch
3 times, most recently
from
80ca5ba
to
3ba9271
Compare
coheigea
reviewed
Sep 10, 2024
core/src/main/java/org/apache/cxf/io/DelayedCachedOutputStreamCleaner.java
Outdated
Show resolved
Hide resolved
reta
force-pushed
the
CXF-7396
branch
2 times, most recently
from
6a8ed4c
to
26eaf39
Compare
coheigea
approved these changes
Sep 19, 2024
reta
added a commit
that referenced
this pull request
Sep 22, 2024
* CXF-7396: CachedOutputStream doesn't delete temp files * Refactor the cleaner implementation and add guardrails for cleaner delay (cherry picked from commit 03a85a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CachedOutputStreamdoesn't delete temp files. it turned out to be very challenging to handle all the edge (and non-edge) cases whereCachedOutputStreams (or derived) streams stay unclosed. This change does not solve the root cause of the problem but offers at least a mitigation strategy in a shape ofCachedOutputStreamCleanerthat tracks unclosedCachedOutputStreams (or derived) streams and periodically tries to close those out.