Remove numbers from CLI integration test names #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevedlawrence
requested changes
Dec 11, 2023
daffodil-test-integration/src/test/scala/org/apache/daffodil/cliTest/TestCLIDebugger.scala
Show resolved
Hide resolved
stevedlawrence
approved these changes
Dec 11, 2023
tuxji
approved these changes
Dec 11, 2023
| @@ -220,7 +220,7 @@ class TestCLIParsing { | |||
| }(ExitCode.Success) | |||
| } | |||
|
|
|||
| @Test def test_1317_IBMCompatibility_ABC_test_ibm_abc_cli(): Unit = { | |||
| @Test def test_IBMCompatibility_ABC_test_ibm_abc_cli(): Unit = { | |||
There was a problem hiding this comment.
Could rename to test_CLI_IBMCompatibility_ABC_test_ibm_abc to be more similar to rest of test case names, any disagreement?
DAFFODIL-2753 TestCLIDebugger.scala: remove numbers from test names. TestCLIParsing.scala: remove numbers from test names. TestCLIPerformance.scala: remove numbers from test names. TestCLISaveParser.scala: remove numbers from test names. TestCLItdml.scala: remove numbers from test names. TestCLIUnparsing.scala: remove numbers from test names.
pkatlic
force-pushed
the
daffodil-2753-remove-cli-numbers
branch
from
afc51ba to
d3af4f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove numbers from CLI integration test names
TestCLIDebugger.scala: remove numbers from test names.
TestCLIParsing.scala: remove numbers from test names.
TestCLIPerformance.scala: remove numbers from test names.
TestCLISaveParser.scala: remove numbers from test names.
TestCLItdml.scala: remove numbers from test names.
TestCLIUnparsing.scala: remove numbers from test names.
DAFFODIL-2753