Skip to content

Conversation

@mbutrovich
Copy link
Contributor

@mbutrovich mbutrovich commented Nov 7, 2025

Which issue does this PR close?

N/A.

Rationale for this change

I have no idea why it didn't manifest until now, but in #2729 there were failures related to division with floats, and operations were being applied to batches coming in with unexpected schemas. Basically NormalizeNaNAndZero was bypassing a cast child and accessing the cast's child directly whenever children() was called. I have no idea why this isn't broken on main, but it seems wrong from looking at it, and it resolved the test failures in #2729.

What changes are included in this PR?

Change children() to rethrn NormalizeNaNAndZero's child, instead of its child's child.

How are these changes tested?

Existing tests.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.33%. Comparing base (f09f8af) to head (3421af2).
⚠️ Report is 674 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2732      +/-   ##
============================================
+ Coverage     56.12%   59.33%   +3.20%     
- Complexity      976     1436     +460     
============================================
  Files           119      147      +28     
  Lines         11743    13819    +2076     
  Branches       2251     2372     +121     
============================================
+ Hits           6591     8199    +1608     
- Misses         4012     4391     +379     
- Partials       1140     1229      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbutrovich mbutrovich merged commit f807c63 into apache:main Nov 7, 2025
119 of 128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants