fix: NormalizeNaNAndZero::children() returns child's child #2732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A.
Rationale for this change
I have no idea why it didn't manifest until now, but in #2729 there were failures related to division with floats, and operations were being applied to batches coming in with unexpected schemas. Basically
NormalizeNaNAndZerowas bypassing a cast child and accessing the cast's child directly wheneverchildren()was called. I have no idea why this isn't broken on main, but it seems wrong from looking at it, and it resolved the test failures in #2729.What changes are included in this PR?
Change
children()to rethrnNormalizeNaNAndZero's child, instead of its child's child.How are these changes tested?
Existing tests.