Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: Support trailing commas in column definitions list #1682

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

iffyio
Copy link
Contributor

@iffyio iffyio commented Jan 24, 2025

Adds support for BigQuery's CREATE statement containing trailing commas in the columns definitions list

CREATE TABLE T (x INT64, y INT64,);

https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#create_table_statement

Adds support for BigQuery's `CREATE` statement containing
trailing commas in the columns definitions list

```sql
CREATE TABLE T (x INT64, y INT64,);
```
Copy link
Contributor

@yoavcloud yoavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iffyio and @yoavcloud

@alamb alamb merged commit fd6c98e into apache:main Jan 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants