Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve MySQL-style LIMIT <offset>, <limit> syntax #1765

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

mvzink
Copy link
Contributor

@mvzink mvzink commented Mar 11, 2025

We already parse it, but were rewriting it into standard LIMIT <limit> OFFSET <offset> syntax. Now we preserve the original syntax.

@mvzink mvzink force-pushed the push-yzwkuqxwyrom branch from 4e65140 to b428b0f Compare March 11, 2025 16:44
@mvzink mvzink force-pushed the push-yzwkuqxwyrom branch 2 times, most recently from d520117 to 07a9b59 Compare March 12, 2025 18:08
We already parse it, but were rewriting it into standard `LIMIT <limit>
OFFSET <offset>` syntax. Now we preserve the original syntax.
@mvzink mvzink force-pushed the push-yzwkuqxwyrom branch from 07a9b59 to 9449e69 Compare March 12, 2025 19:11
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mvzink!
cc @alamb

@iffyio iffyio merged commit fb578bb into apache:main Mar 12, 2025
9 checks passed
@alamb
Copy link
Contributor

alamb commented Mar 12, 2025

Love it -- thank you @mvzink and @iffyio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants