Consolidate statistics merging code #15645
Closed
+308
−327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
commented
Apr 8, 2025
| }) | ||
| } | ||
|
|
||
| /// Merge this Statistics value with another Statistics value. |
There was a problem hiding this comment.
This is the core logic for merging one Statistics instance with another
alamb
commented
Apr 8, 2025
| @@ -433,6 +480,79 @@ fn check_num_rows(value: Option<usize>, is_exact: bool) -> Precision<usize> { | |||
| } | |||
| } | |||
|
|
|||
| pub fn add_row_stats( | |||
There was a problem hiding this comment.
These methods had to remain pub for now as they are also used in the listing table statistics summary code. I will look into that and see if it makes sense to do as a individual PR
| @@ -798,4 +920,173 @@ mod tests { | |||
| distinct_count: Precision::Exact(100), | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_merge_iter_basic() { | |||
There was a problem hiding this comment.
these are just tests moved from datasource
| @@ -409,62 +409,6 @@ pub async fn get_statistics_with_limit( | |||
| Ok((result_files, statistics)) | |||
| } | |||
|
|
|||
| /// Generic function to compute statistics across multiple items that have statistics | |||
| fn compute_summary_statistics<T, I>( | |||
There was a problem hiding this comment.
This code was moved into Statistics
|
Just noticed the PR. FYI, I've reviewed it in the PR: xudong963#5 |
|
Thanks @xudong963 -- I will work on this in a follow on PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
statistics_by_partition APIto ExecutionPlan #15503statistics_by_partitionAPI toExecutionPlan#15495Rationale for this change
While reviewing #15503 from @xudong963 I noticed he had to move
compute_summary_statisticsanywaysWhat changes are included in this PR?
Statistics::merge_iterandStatistics::mergeAre these changes tested?
Yes (by existing tests)
Are there any user-facing changes?