Skip to content

Conversation

@r1b
Copy link
Contributor

@r1b r1b commented Oct 19, 2025

Which issue does this PR close?

Rationale for this change

This makes it possible to support temporary views in datafusion-python without code duplication.

Ref: apache/datafusion-python#1267

What changes are included in this PR?

  • Add new public function DataFrame::into_temporary_view
  • Update DataFrameTableProvider with a new member that determines the table_type
  • Add a test

Are these changes tested?

Yes, see added test register_temporary_table

Are there any user-facing changes?

Yes, there is a new public function DataFrame::into_temporary_view

@github-actions github-actions bot added the core Core DataFusion crate label Oct 19, 2025
Copy link
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine to me, but would be good if @timsaucer could put some eyes on this too

Copy link
Member

@timsaucer timsaucer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Thanks for taking this on. Just one question, but I think it's simple.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to keep the code flowing and I had this PR opened so I took the liberty of merging this PR up from main and pushing a commit to remove the new enum

@r1b
Copy link
Contributor Author

r1b commented Oct 29, 2025

Thanks @alamb LGTM

@alamb alamb added this pull request to the merge queue Oct 29, 2025
@alamb
Copy link
Contributor

alamb commented Oct 29, 2025

Thanks @r1b and @timsaucer and @Jefffrey

Merged via the queue into apache:main with commit 0a650a0 Oct 29, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance DataFrame table provider to support temporary views

4 participants