feat: Naive deduplicating recursive CTE implementation #18184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
- introduce a new "result table" intermediate table storing all already emitted results - use existing physical operators to deduplicate the output of both static and recursive terms and remove from the recursive term output the already emitted results - add a simple test of a transitive closure on a cyclic graph
Tpt
changed the title
|
Much better implementation in #18254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very naive and slow. It would be much better to build the result table as a hash table inside of
RecursiveQueryExecand use if for deduplication, removing the need for any extra operator. I guess it will requires significant coding because we need an incremental hash map (build and probe steps are interleaved).Edit: made it a draft, I want to experiment with hash table first.
UNIONin recursive CTE #18140