fix: CteWorkTable: properly apply TableProvider::scan projection argument #18993
+97
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
catalog
Tpt
changed the title
martin-g
reviewed
Nov 30, 2025
| drop(memory_stream); | ||
| assert_eq!(pool.reserved(), 0); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
It would be good to add a test case using projection.
| work_table: Arc<WorkTable>, | ||
| /// Execution metrics | ||
| metrics: ExecutionPlanMetricsSet, | ||
| /// Cache holding plan properties like equivalences, output partitioning etc. |
Member
There was a problem hiding this comment.
The docstring is outdated now. The field is not named cache anymore.
Contributor
Author
There was a problem hiding this comment.
Indeed, I have moved back the field name to cache to stay consistent with a lot of other operator implementations: 69464d2
Tpt
force-pushed
the
tpt/cteworktable-projection
branch
from
da29338 to
304d40c
Compare
martin-g
approved these changes
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously ignored
Which issue does this PR close?
CteWorkTabledoes not properly apply projection #18992.Rationale for this change
All
TableProviderimplementations must support theprojectionargument of thescanmethod. This was not the case inCteWorkTable.What changes are included in this PR?
Minimal implementation of the projection support. The projection applied before the plan node return results. It might be nice to push it further inside of the recursion implementation to reduce memory consumption but I preferred to keep the fix minimal.
Are these changes tested?
I have not figured out yet a nice SQL query to trigger an error without this change. Some existing queries in
cte.slthave set projection (i.e. notNone) so the code is very likely working. There is also a test on the projection itself inWorkTableExec