Skip to content

chore: remove denys of needless_pass_by_value in lib.rs files #18996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove denys of needless_pass_by_value in lib.rs files #18996

wants to merge 1 commit into from
+1 −72

Conversation

@Jefffrey
Copy link
Contributor

@Jefffrey Jefffrey commented Nov 30, 2025

Which issue does this PR close?

Rationale for this change

Lint already enforced at the workspace level so don't need to have these individual denies in each lib.rs (still maintain exclusion for tests though).

What changes are included in this PR?

Remove #![deny(clippy::needless_pass_by_value)] in each lib.rs.

Are these changes tested?

Manually tested; the lint still seems to work, e.g. when I comment out an #[expect(clippy::needless_pass_by_value)] then clippy still flags it due to workspace lint rules.

Are there any user-facing changes?

No.

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate substrait Changes to the substrait crate catalog Related to the catalog crate common Related to common crate execution Related to the execution crate proto Related to proto crate functions Changes to functions implementation datasource Changes to the datasource crate ffi Changes to the ffi crate physical-plan Changes to the physical-plan crate spark labels Nov 30, 2025
@Jefffrey Jefffrey mentioned this pull request Nov 30, 2025
Open
@Jefffrey Jefffrey marked this pull request as ready for review November 30, 2025 02:36
@Jefffrey Jefffrey requested a review from 2010YOUY01 November 30, 2025 02:36
2010YOUY01
2010YOUY01 approved these changes Nov 30, 2025
View reviewed changes
Copy link
Contributor

@2010YOUY01 2010YOUY01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2010YOUY01 2010YOUY01 2010YOUY01 approved these changes

Assignees

No one assigned

Labels

catalog Related to the catalog crate common Related to common crate core Core DataFusion crate datasource Changes to the datasource crate execution Related to the execution crate ffi Changes to the ffi crate functions Changes to functions implementation logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates physical-plan Changes to the physical-plan crate proto Related to proto crate spark sql SQL Planner substrait Changes to the substrait crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jefffrey @2010YOUY01