Skip to content

Add guard for test in sampling sketch #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proost merged 1 commit into from
Feb 3, 2026
Merged

Add guard for test in sampling sketch #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions sampling/compatibility_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,12 @@ func TestGenerateGoBinariesForCompatibilityTesting(t *testing.T) {

// TestSerializationCompatibilityEmpty tests deserialization of an empty sketch.
func TestSerializationCompatibilityEmpty(t *testing.T) {
data, err := os.ReadFile(filepath.Join(internal.GoPath, "reservoir_items_long_empty_k128_go.sk"))
filename := filepath.Join(internal.GoPath, "reservoir_items_long_empty_k128_go.sk")
if _, err := os.Stat(filename); os.IsNotExist(err) {
t.Skipf("Go file not found: %s", filename)
return
}
data, err := os.ReadFile(filename)
assert.NoError(t, err)

sketch, err := NewReservoirItemsSketchFromSlice[int64](data, Int64SerDe{})
Expand All @@ -277,7 +282,12 @@ func TestSerializationCompatibilityExact(t *testing.T) {

for _, tc := range testCases {
t.Run(tc.filename, func(t *testing.T) {
data, err := os.ReadFile(filepath.Join(internal.GoPath, tc.filename))
filename := filepath.Join(internal.GoPath, tc.filename)
if _, err := os.Stat(filename); os.IsNotExist(err) {
t.Skipf("Go file not found: %s", filename)
return
}
data, err := os.ReadFile(filename)
assert.NoError(t, err)

sketch, err := NewReservoirItemsSketchFromSlice[int64](data, Int64SerDe{})
Expand All @@ -303,7 +313,12 @@ func TestSerializationCompatibilityWithSampling(t *testing.T) {

for _, tc := range testCases {
t.Run(tc.filename, func(t *testing.T) {
data, err := os.ReadFile(filepath.Join(internal.GoPath, tc.filename))
filename := filepath.Join(internal.GoPath, tc.filename)
if _, err := os.Stat(filename); os.IsNotExist(err) {
t.Skipf("Go file not found: %s", filename)
return
}
data, err := os.ReadFile(filename)
assert.NoError(t, err)

sketch, err := NewReservoirItemsSketchFromSlice[int64](data, Int64SerDe{})
Expand Down
Loading